From 29f7f06ab0f3ff6c7c506566d1535cd4f7da52ee Mon Sep 17 00:00:00 2001 From: Sebastian Date: Sun, 1 Feb 2026 20:47:05 +0100 Subject: [PATCH] alignment --- .../Controllers/RegistrationController.cs | 12 +++--------- src/Web/lan-frontend/app/register/page.tsx | 10 +++++----- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/Registration/Registration.API/Controllers/RegistrationController.cs b/src/Registration/Registration.API/Controllers/RegistrationController.cs index fca730b..1068826 100644 --- a/src/Registration/Registration.API/Controllers/RegistrationController.cs +++ b/src/Registration/Registration.API/Controllers/RegistrationController.cs @@ -27,21 +27,15 @@ namespace Registration.API.Controllers public async Task RegisterMember(string ssn) { var added = await _memberRepository.AddRegistration(ssn); - if (added) - { - return Ok(new { Message = "Member registered successfully." }); - } - else - { - return Conflict(new { Message = "Member is already registered." }); - } + + return added ? Ok() : Conflict(); } [HttpGet("registered/{ssn}")] public async Task IsMemberRegistered(string ssn) { var isRegistered = await _memberRepository.GetIsRegistered(ssn); - return Ok(new { IsRegistered = isRegistered }); + return isRegistered ? Conflict() : Ok(); } [HttpDelete("clear")] diff --git a/src/Web/lan-frontend/app/register/page.tsx b/src/Web/lan-frontend/app/register/page.tsx index bec8f8b..8fdbdf4 100644 --- a/src/Web/lan-frontend/app/register/page.tsx +++ b/src/Web/lan-frontend/app/register/page.tsx @@ -47,19 +47,19 @@ export default function RegisterPage() { try { // 1. Check if the SSN has already been registered for the LAN + // Returns Ok (200) if NOT registered, Conflict (409) if registered const checkRes = await fetch(`/api/Registration/registered/${formData.ssn}`); - const checkData = await checkRes.json(); - - if (checkData.isRegistered) { + + if (checkRes.status === 409) { setMessage({ type: "error", text: "This SSN is already registered for the LAN." }); setIsSubmitting(false); return; } // 2. Check membership status via GET Registration register - // Returns 200 (Ok) if member, 204 (NoContent) if not + // Returns 200 (Ok) if member, 404 (NotFound) if not const validateRes = await fetch(`/api/Registration/register/${formData.ssn}`); - const isMember = validateRes.status === 200; + const isMember = validateRes.ok; // 3. Register the SSN in the membership system via POST await fetch(`/api/Registration/register/${formData.ssn}`, {